Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/cant create survey in demo #884

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Fix/cant create survey in demo #884

merged 3 commits into from
Dec 10, 2024

Conversation

MailineN
Copy link
Contributor

@MailineN MailineN commented Dec 9, 2024

  • Make series-related fields optional if no series are retrieved from the backend or mock data.
  • Minor UI adjustment to indicate mandatory fields.

laurentC35
laurentC35 requested changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@laurentC35 laurentC35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor fix to do 😉

src/widgets/statistical-context-criteria/containers/statistical-context-criteria.jsx Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@MailineN MailineN merged commit 5409ac0 into 1.7 Dec 10, 2024
8 checks passed
@MailineN MailineN deleted the fix/cant-create-survey-in-demo branch December 10, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentC35 laurentC35 laurentC35 requested changes

@QRuhier QRuhier QRuhier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MailineN @laurentC35 @QRuhier